2015-07-31 05:41:53 +02:00
|
|
|
From 6e5dae727f6c1841733255c643684dd8631ee850 Mon Sep 17 00:00:00 2001
|
2015-06-16 14:55:15 +02:00
|
|
|
From: Byteflux <byte@byteflux.net>
|
|
|
|
Date: Tue, 16 Jun 2015 05:52:58 -0700
|
|
|
|
Subject: [PATCH] Optimize explosions
|
|
|
|
|
|
|
|
The process of determining an entity's exposure from explosions can be
|
|
|
|
expensive when there are hundreds or more entities in range.
|
|
|
|
|
|
|
|
This patch adds a per-tick cache that is used for storing and retrieving
|
|
|
|
an entity's exposure during an explosion.
|
|
|
|
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/Explosion.java b/src/main/java/net/minecraft/server/Explosion.java
|
2015-07-31 05:41:53 +02:00
|
|
|
index a078799..0f722c2 100644
|
2015-06-16 14:55:15 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/Explosion.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/Explosion.java
|
|
|
|
@@ -129,7 +129,7 @@ public class Explosion {
|
|
|
|
d8 /= d11;
|
|
|
|
d9 /= d11;
|
|
|
|
d10 /= d11;
|
|
|
|
- double d12 = (double) this.world.a(vec3d, entity.getBoundingBox());
|
|
|
|
+ double d12 = this.getBlockDensity(vec3d, entity.getBoundingBox()); // PaperSpigot - Optimize explosions
|
|
|
|
double d13 = (1.0D - d7) * d12;
|
|
|
|
|
|
|
|
// entity.damageEntity(DamageSource.explosion(this), (float) ((int) ((d13 * d13 + d13) / 2.0D * 8.0D * (double) f3 + 1.0D)));+ // CraftBukkit start
|
2015-07-31 05:41:53 +02:00
|
|
|
@@ -293,4 +293,86 @@ public class Explosion {
|
2015-06-16 14:55:15 +02:00
|
|
|
public List<BlockPosition> getBlocks() {
|
|
|
|
return this.blocks;
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ // PaperSpigot start - Optimize explosions
|
|
|
|
+ private float getBlockDensity(Vec3D vec3d, AxisAlignedBB aabb) {
|
|
|
|
+ if (!this.world.paperSpigotConfig.optimizeExplosions) {
|
|
|
|
+ return this.world.a(vec3d, aabb);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ CacheKey key = new CacheKey(this, aabb);
|
|
|
|
+ Float blockDensity = this.world.explosionDensityCache.get(key);
|
|
|
|
+ if (blockDensity == null) {
|
|
|
|
+ blockDensity = this.world.a(vec3d, aabb);
|
|
|
|
+ this.world.explosionDensityCache.put(key, blockDensity);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ return blockDensity;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ static class CacheKey {
|
|
|
|
+ private final World world;
|
|
|
|
+ private final double posX, posY, posZ;
|
|
|
|
+ private final double minX, minY, minZ;
|
|
|
|
+ private final double maxX, maxY, maxZ;
|
|
|
|
+
|
|
|
|
+ public CacheKey(Explosion explosion, AxisAlignedBB aabb) {
|
|
|
|
+ this.world = explosion.world;
|
|
|
|
+ this.posX = explosion.posX;
|
|
|
|
+ this.posY = explosion.posY;
|
|
|
|
+ this.posZ = explosion.posZ;
|
|
|
|
+ this.minX = aabb.a;
|
|
|
|
+ this.minY = aabb.b;
|
|
|
|
+ this.minZ = aabb.c;
|
|
|
|
+ this.maxX = aabb.d;
|
|
|
|
+ this.maxY = aabb.e;
|
|
|
|
+ this.maxZ = aabb.f;
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public boolean equals(Object o) {
|
|
|
|
+ if (this == o) return true;
|
|
|
|
+ if (o == null || getClass() != o.getClass()) return false;
|
|
|
|
+
|
|
|
|
+ CacheKey cacheKey = (CacheKey) o;
|
|
|
|
+
|
|
|
|
+ if (Double.compare(cacheKey.posX, posX) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.posY, posY) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.posZ, posZ) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.minX, minX) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.minY, minY) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.minZ, minZ) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.maxX, maxX) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.maxY, maxY) != 0) return false;
|
|
|
|
+ if (Double.compare(cacheKey.maxZ, maxZ) != 0) return false;
|
|
|
|
+ return world.equals(cacheKey.world);
|
|
|
|
+ }
|
|
|
|
+
|
|
|
|
+ @Override
|
|
|
|
+ public int hashCode() {
|
|
|
|
+ int result;
|
|
|
|
+ long temp;
|
|
|
|
+ result = world.hashCode();
|
|
|
|
+ temp = Double.doubleToLongBits(posX);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(posY);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(posZ);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(minX);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(minY);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(minZ);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(maxX);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(maxY);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ temp = Double.doubleToLongBits(maxZ);
|
|
|
|
+ result = 31 * result + (int) (temp ^ (temp >>> 32));
|
|
|
|
+ return result;
|
|
|
|
+ }
|
|
|
|
+ }
|
|
|
|
+ // PaperSpigot end
|
|
|
|
}
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/MinecraftServer.java b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2015-07-31 05:41:53 +02:00
|
|
|
index 76ba101..c9a2ed7 100644
|
2015-06-16 14:55:15 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/MinecraftServer.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/MinecraftServer.java
|
2015-07-26 22:58:37 +02:00
|
|
|
@@ -860,6 +860,7 @@ public abstract class MinecraftServer implements Runnable, ICommandListener, IAs
|
2015-06-16 14:55:15 +02:00
|
|
|
worldserver.timings.tracker.stopTiming(); // Spigot
|
|
|
|
this.methodProfiler.b();
|
|
|
|
this.methodProfiler.b();
|
|
|
|
+ worldserver.explosionDensityCache.clear(); // PaperSpigot - Optimize explosions
|
|
|
|
// } // CraftBukkit
|
|
|
|
|
|
|
|
// this.i[i][this.ticks % 100] = System.nanoTime() - j; // CraftBukkit
|
|
|
|
diff --git a/src/main/java/net/minecraft/server/World.java b/src/main/java/net/minecraft/server/World.java
|
2015-07-26 22:58:37 +02:00
|
|
|
index b3e77d5..39cf1a3 100644
|
2015-06-16 14:55:15 +02:00
|
|
|
--- a/src/main/java/net/minecraft/server/World.java
|
|
|
|
+++ b/src/main/java/net/minecraft/server/World.java
|
2015-07-01 09:27:58 +02:00
|
|
|
@@ -133,6 +133,7 @@ public abstract class World implements IBlockAccess {
|
2015-06-16 14:55:15 +02:00
|
|
|
public static String blockLocation;
|
|
|
|
private int tileTickPosition;
|
2015-07-01 09:27:58 +02:00
|
|
|
private ExecutorService lightingExecutor; // PaperSpigot - Asynchronous lighting updates
|
2015-06-16 14:55:15 +02:00
|
|
|
+ public final Map<Explosion.CacheKey, Float> explosionDensityCache = new HashMap<Explosion.CacheKey, Float>(); // PaperSpigot - Optimize explosions
|
|
|
|
|
|
|
|
public static long chunkToKey(int x, int z)
|
|
|
|
{
|
|
|
|
diff --git a/src/main/java/org/github/paperspigot/PaperSpigotWorldConfig.java b/src/main/java/org/github/paperspigot/PaperSpigotWorldConfig.java
|
2015-07-01 04:46:05 +02:00
|
|
|
index 0b75e16..4596e9d 100644
|
2015-06-16 14:55:15 +02:00
|
|
|
--- a/src/main/java/org/github/paperspigot/PaperSpigotWorldConfig.java
|
|
|
|
+++ b/src/main/java/org/github/paperspigot/PaperSpigotWorldConfig.java
|
2015-07-01 04:46:05 +02:00
|
|
|
@@ -338,4 +338,10 @@ public class PaperSpigotWorldConfig
|
2015-06-16 14:55:15 +02:00
|
|
|
{
|
|
|
|
fallingBlocksCollideWithSigns = getBoolean( "falling-blocks-collide-with-signs", false );
|
|
|
|
}
|
|
|
|
+
|
|
|
|
+ public boolean optimizeExplosions;
|
|
|
|
+ private void optimizeExplosions()
|
|
|
|
+ {
|
|
|
|
+ optimizeExplosions = getBoolean( "optimize-explosions", false );
|
|
|
|
+ }
|
|
|
|
}
|
|
|
|
--
|
2015-07-26 22:58:37 +02:00
|
|
|
2.4.5.windows.1
|
2015-06-16 14:55:15 +02:00
|
|
|
|