From 0ad24ce47b1ef30886bf81103e2a8dfcf1a63b69 Mon Sep 17 00:00:00 2001
From: Sam <huzzahpinkyoshi@gmail.com>
Date: Sun, 10 Jun 2018 16:00:34 +0100
Subject: [PATCH] Fix a cake wars dupe bug

---
 .../game/games/cakewars/ui/CakeResourcePage.java | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/Plugins/Nautilus.Game.Arcade/src/nautilus/game/arcade/game/games/cakewars/ui/CakeResourcePage.java b/Plugins/Nautilus.Game.Arcade/src/nautilus/game/arcade/game/games/cakewars/ui/CakeResourcePage.java
index ebad6bafb..96b4adf50 100644
--- a/Plugins/Nautilus.Game.Arcade/src/nautilus/game/arcade/game/games/cakewars/ui/CakeResourcePage.java
+++ b/Plugins/Nautilus.Game.Arcade/src/nautilus/game/arcade/game/games/cakewars/ui/CakeResourcePage.java
@@ -61,7 +61,7 @@ public class CakeResourcePage extends ShopPageBase<ArcadeManager, CakeResourceSh
 		{
 			CakeShopResult result = getResultPurchase(item);
 
-			addButton(slot, prepareItem(item, result), new CakeShopButton(item, result));
+			addButton(slot, prepareItem(item, result), new CakeShopButton(item));
 
 			if (++slot % 9 == 8)
 			{
@@ -198,12 +198,10 @@ public class CakeResourcePage extends ShopPageBase<ArcadeManager, CakeResourceSh
 	{
 
 		private final CakeItem _item;
-		private final CakeShopResult _result;
 
-		CakeShopButton(CakeItem item, CakeShopResult result)
+		CakeShopButton(CakeItem item)
 		{
 			_item = item;
-			_result = result;
 		}
 
 		@Override
@@ -213,9 +211,15 @@ public class CakeResourcePage extends ShopPageBase<ArcadeManager, CakeResourceSh
 			{
 				return;
 			}
-			else if (_result != CakeShopResult.SUCCESSFUL)
+
+			// It's important to re-get the result otherwise it's possible to do a very
+			// quick but difficult dupe bug. Involving opening the ui and dropping the items
+			// at the same time.
+			CakeShopResult result = getResultPurchase(_item);
+
+			if (result != CakeShopResult.SUCCESSFUL)
 			{
-				player.sendMessage(F.main("Game", _result.getFeedback()));
+				player.sendMessage(F.main("Game", result.getFeedback()));
 				playDenySound(player);
 				return;
 			}