Make some changes to make IntelliJ's code inspection happier

src/main/java/net/frozenorb/apiv3/APIv3.java

@@ -99,7 +99,7 @@ public final class APIv3 extends AbstractVerticle {
 
     @Getter private static Vertx vertxInstance;
     @Getter private static MongoDatabase database;
-    @Getter private static Properties config = new Properties();
+    @Getter private static final Properties config = new Properties();
     private static final Gson gson = new GsonBuilder()
         .registerTypeAdapter(Instant.class, new InstantTypeAdapter())
         .setExclusionStrategies(new FollowAnnotationExclusionStrategy())

src/main/java/net/frozenorb/apiv3/maxmind/MaxMindUserType.java

@@ -21,7 +21,7 @@ public enum MaxMindUserType {
     TRAVELER(true),
     UNKNOWN(true);
 
-    @Getter private boolean allowed;
+    @Getter private final boolean allowed;
 
     MaxMindUserType(boolean allowed) {
         this.allowed = allowed;

src/main/java/net/frozenorb/apiv3/model/BannedAsn.java

@@ -43,10 +43,7 @@ public final class BannedAsn {
 
     static {
         updateCache();
-
+        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> updateCache());
-        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> {
-            updateCache();
-        });
     }
 
     private static void updateCache() {

src/main/java/net/frozenorb/apiv3/model/Rank.java

@@ -43,10 +43,7 @@ public final class Rank {
 
     static {
         updateCache();
-
+        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> updateCache());
-        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> {
-            updateCache();
-        });
     }
 
     private static void updateCache() {

src/main/java/net/frozenorb/apiv3/model/Server.java

@@ -45,10 +45,7 @@ public final class Server {
 
     static {
         updateCache();
-
+        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> updateCache());
-        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> {
-            updateCache();
-        });
     }
 
     private static void updateCache() {

src/main/java/net/frozenorb/apiv3/model/ServerGroup.java

@@ -41,10 +41,7 @@ public final class ServerGroup {
 
     static {
         updateCache();
-
+        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> updateCache());
-        APIv3.getVertxInstance().setPeriodic(TimeUnit.MINUTES.toMillis(1), (id) -> {
-            updateCache();
-        });
     }
 
     private static void updateCache() {

src/main/java/net/frozenorb/apiv3/route/auditLog/GETAuditLog.java

@@ -22,7 +22,7 @@ public final class GETAuditLog implements Handler<RoutingContext> {
                     APIv3.respondJson(ctx, auditLog);
                 }
             });
-        } catch (NumberFormatException ex) {
+        } catch (NumberFormatException ignored) {
             ErrorUtils.respondInvalidInput(ctx, "skip and pageSize must be numerical inputs.");
         }
     }

src/main/java/net/frozenorb/apiv3/route/auditLog/POSTAuditLog.java

@@ -32,7 +32,7 @@ public final class POSTAuditLog implements Handler<RoutingContext> {
 
                 try {
                     type = AuditLogActionType.valueOf(requestBody.getString("type"));
-                } catch (IllegalArgumentException ex) {
+                } catch (IllegalArgumentException ignored) {
                     ErrorUtils.respondNotFound(ctx, "Audit log action type", requestBody.getString("type"));
                     return;
                 }

src/main/java/net/frozenorb/apiv3/route/grants/GETGrants.java

@@ -21,7 +21,7 @@ public final class GETGrants implements Handler<RoutingContext> {
                     APIv3.respondJson(ctx, grants);
                 }
             });
-        } catch (NumberFormatException ex) {
+        } catch (NumberFormatException ignored) {
             ErrorUtils.respondInvalidInput(ctx, "skip and pageSize must be numerical inputs.");
         }
     }

src/main/java/net/frozenorb/apiv3/route/ipBans/GETIpBans.java

@@ -21,7 +21,7 @@ public final class GETIpBans implements Handler<RoutingContext> {
                     APIv3.respondJson(ctx, grants);
                 }
             });
-        } catch (NumberFormatException ex) {
+        } catch (NumberFormatException ignored) {
             ErrorUtils.respondInvalidInput(ctx, "skip and pageSize must be numerical inputs.");
         }
     }

src/main/java/net/frozenorb/apiv3/route/punishments/GETPunishments.java

@@ -21,7 +21,7 @@ public final class GETPunishments implements Handler<RoutingContext> {
                     APIv3.respondJson(ctx, grants);
                 }
             });
-        } catch (NumberFormatException ex) {
+        } catch (NumberFormatException ignored) {
             ErrorUtils.respondInvalidInput(ctx, "skip and pageSize must be numerical inputs.");
         }
     }

src/main/java/net/frozenorb/apiv3/route/servers/POSTServersHeartbeat.java

@@ -114,11 +114,7 @@ public final class POSTServersHeartbeat implements Handler<RoutingContext> {
                 }
 
                 Map<String, Object> response = new HashMap<>();
-
+                loginInfoFutures.forEach((uuid, loginInfo) -> response.put(uuid.toString(), loginInfo.result()));
-                loginInfoFutures.forEach((uuid, loginInfo) -> {
-                    response.put(uuid.toString(), loginInfo.result());
-                });
-
                 callback.complete(response);
             });
         });

src/main/java/net/frozenorb/apiv3/serialization/jackson/InstantJsonDeserializer.java

@@ -11,7 +11,7 @@ import java.time.Instant;
 public final class InstantJsonDeserializer extends JsonDeserializer<Instant> {
 
     @Override
-    public Instant deserialize(JsonParser jsonParser, DeserializationContext deserializationContext) throws IOException, JsonProcessingException {
+    public Instant deserialize(JsonParser jsonParser, DeserializationContext deserializationContext) throws IOException {
         return Instant.ofEpochMilli(jsonParser.getValueAsLong());
     }
 

src/main/java/net/frozenorb/apiv3/serialization/jackson/InstantJsonSerializer.java

@@ -11,7 +11,7 @@ import java.time.Instant;
 public final class InstantJsonSerializer extends JsonSerializer<Instant> {
 
     @Override
-    public void serialize(Instant instant, JsonGenerator jsonGenerator, SerializerProvider serializerProvider) throws IOException, JsonProcessingException {
+    public void serialize(Instant instant, JsonGenerator jsonGenerator, SerializerProvider serializerProvider) throws IOException {
         jsonGenerator.writeNumber(instant.toEpochMilli());
     }
 

src/main/java/net/frozenorb/apiv3/serialization/jackson/UuidJsonDeserializer.java

@@ -11,7 +11,7 @@ import java.util.UUID;
 public final class UuidJsonDeserializer extends JsonDeserializer<UUID> {
 
     @Override
-    public UUID deserialize(JsonParser jsonParser, DeserializationContext deserializationContext) throws IOException, JsonProcessingException {
+    public UUID deserialize(JsonParser jsonParser, DeserializationContext deserializationContext) throws IOException {
         return UUID.fromString(jsonParser.getValueAsString());
     }
 

src/main/java/net/frozenorb/apiv3/serialization/jackson/UuidJsonSerializer.java

@@ -11,7 +11,7 @@ import java.util.UUID;
 public final class UuidJsonSerializer extends JsonSerializer<UUID> {
 
     @Override
-    public void serialize(UUID uuid, JsonGenerator jsonGenerator, SerializerProvider serializerProvider) throws IOException, JsonProcessingException {
+    public void serialize(UUID uuid, JsonGenerator jsonGenerator, SerializerProvider serializerProvider) throws IOException {
         jsonGenerator.writeString(uuid.toString());
     }
 

src/main/java/net/frozenorb/apiv3/serialization/mongodb/UuidCodec.java

@@ -8,7 +8,7 @@ import org.bson.codecs.EncoderContext;
 
 import java.util.UUID;
 
-public final class UuidCodec implements Codec<UUID> {
+final class UuidCodec implements Codec<UUID> {
 
     @Override
     public UUID decode(BsonReader bsonReader, DecoderContext decoderContext) {

src/main/java/net/frozenorb/apiv3/unsorted/TotpAuthorizationResult.java

@@ -10,7 +10,7 @@ public enum TotpAuthorizationResult {
     NOT_AUTHORIZED_RECENTLY_USED(false),
     NOT_AUTHORIZED_BAD_CODE(false);
 
-    @Getter private boolean authorized;
+    @Getter private final boolean authorized;
 
     TotpAuthorizationResult(boolean authorized) {
         this.authorized = authorized;

src/main/java/net/frozenorb/apiv3/util/MandrillUtils.java

@@ -20,13 +20,8 @@ public class MandrillUtils {
                 .put("message", message);
 
         httpClient.post("mandrillapp.com", "/api/1.0/messages/send.json", (response) -> {
-            response.bodyHandler((resultBody) -> {
+            response.bodyHandler((ignored) -> callback.onResult(null, null));
-                callback.onResult(null, null);
+            response.exceptionHandler((error) -> callback.onResult(null, error));
-            });
-
-            response.exceptionHandler((error) -> {
-                callback.onResult(null, error);
-            });
         })
         .putHeader(HttpHeaders.CONTENT_TYPE, MediaType.JSON_UTF_8.toString())
         .end(body.encode());

src/main/java/net/frozenorb/apiv3/util/MaxMindUtils.java

@@ -27,9 +27,7 @@ public class MaxMindUtils {
                 callback.onResult(new MaxMindResult(bodyJson), null);
             });
 
-            response.exceptionHandler((error) -> {
+            response.exceptionHandler((error) -> callback.onResult(null, error));
-                callback.onResult(null, error);
-            });
         })
         .putHeader("Authorization", authHeader)
         .end();

src/main/java/net/frozenorb/apiv3/util/MojangUtils.java

@@ -33,9 +33,7 @@ public class MojangUtils {
                 }
             });
 
-            response.exceptionHandler((error) -> {
+            response.exceptionHandler((error) -> callback.onResult(null, error));
-                callback.onResult(null, error);
-            });
         }).end();
     }
 

src/main/java/net/frozenorb/apiv3/util/ZangUtils.java

@@ -37,9 +37,7 @@ public class ZangUtils {
                 }
             });
 
-            response.exceptionHandler((error) -> {
+            response.exceptionHandler((error) -> callback.onResult(null, error));
-                callback.onResult(null, error);
-            });
         })
         .putHeader("Authorization", authHeader)
         .putHeader(HttpHeaders.CONTENT_TYPE, MediaType.JSON_UTF_8.toString())